Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mousai: init at 0.3.1 #118498

Closed
wants to merge 7 commits into from
Closed

mousai: init at 0.3.1 #118498

wants to merge 7 commits into from

Conversation

onny
Copy link
Contributor

@onny onny commented Apr 4, 2021

Motivation for this change

Package music recognition tool mousai

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mousai/default.nix Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Apr 6, 2021

Thank you @fabaff and @SuperSandro2000 for the feedback. All remarks should be fixed now :)

@onny
Copy link
Contributor Author

onny commented Apr 10, 2021

Not sure about the wrapping issue but maybe it is okay at this stage :)

@SuperSandro2000
Copy link
Member

Not sure about the wrapping issue but maybe it is okay at this stage :)

Looks better but still double wrapped

.r-xr-xr-x root root 2.8 KB Thu Jan  1 01:00:01 1970  ..mousai-wrapped-wrapped
.r-xr-xr-x root root 4.4 KB Thu Jan  1 01:00:01 1970  .mousai-wrapped
.r-xr-xr-x root root 3.6 KB Thu Jan  1 01:00:01 1970  mousai

@onny onny changed the title mousai: init at 0.2.0 mousai: init at 0.3.1 Apr 24, 2021
@onny
Copy link
Contributor Author

onny commented Apr 24, 2021

Sorry, I moved my local changes to a separate branch. New pull request is here: #120515
Hopefully it should also solve the issue of nested wrappers :)

@onny onny closed this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants