Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.NetCIDRLite: 0.21 -> 0.22 #118607

Merged

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Apr 5, 2021

Motivation for this change

https://metacpan.org/release/Net-CIDR-Lite

Removed patch for vulnerability that's is now included upstream

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Removed patch that is now in upstream
@SuperSandro2000
Copy link
Member

If I would understand cpan.. How did you adopt the package?

@stigtsp
Copy link
Member Author

stigtsp commented Apr 5, 2021

If I would understand cpan.. How did you adopt the package?

The maintainer asked if I'd like to adopt it after the patch was submitted.

PS: NEILB has a nice overview here of distros up for adoption https://neilb.org/adoption/ and some general info here https://neilb.org/2013/07/24/adopt-a-module.html

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 5, 2021

Result of nixpkgs-review pr 118607 at 8fca47f run on x86_64-linux 1

9 packages built successfully:
  • almanah
  • evolution
  • evolution-ews
  • evolutionWithPlugins
  • perl530Packages.NetCIDRLite
  • perl530Packages.NetPatricia
  • perl532Packages.NetCIDRLite
  • perl532Packages.NetPatricia
  • spamassassin

Result of nixpkgs-review pr 118607 at 8fca47f run on aarch64-linux 1

8 packages built successfully:
  • almanah
  • evolution
  • evolution-ews
  • perl530Packages.NetCIDRLite
  • perl530Packages.NetPatricia
  • perl532Packages.NetCIDRLite
  • perl532Packages.NetPatricia
  • spamassassin

@SuperSandro2000 SuperSandro2000 merged commit 5343c04 into NixOS:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants