Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wakeonlan: 1.1.6 -> 2.0.0 #118765

Merged
merged 1 commit into from
Apr 8, 2021
Merged

python3Packages.wakeonlan: 1.1.6 -> 2.0.0 #118765

merged 1 commit into from
Apr 8, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 7, 2021

Motivation for this change

Update to latest upstream release 2.0.0

Change log: https://github.com/remcohaszing/pywakeonlan/releases/tag/2.0.0

openwebifpy is only available for Python > 3.6. Thus, wakeonlan as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Apr 7, 2021

Result of nixpkgs-review pr 118765 run on x86_64-linux 1

4 packages built:
  • python38Packages.openwebifpy
  • python38Packages.wakeonlan
  • python39Packages.openwebifpy
  • python39Packages.wakeonlan

@fabaff
Copy link
Member Author

fabaff commented Apr 8, 2021

@ofborg eval

@ofborg ofborg bot requested a review from peterhoeg April 8, 2021 06:58
@SuperSandro2000 SuperSandro2000 merged commit 88cd214 into NixOS:master Apr 8, 2021
@fabaff fabaff deleted the bump-wakeonlan branch April 8, 2021 13:22
@fabaff fabaff mentioned this pull request Apr 8, 2021
Merged
@remcohaszing
Copy link

Nitpick: The license should be updated to MIT.

@SuperSandro2000
Copy link
Member

Changed in f37e906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @remcohaszing @SuperSandro2000