Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foxotron: init at 2021-03-12 #118807

Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Apr 8, 2021

Motivation for this change

Package Foxotron, a Public Domain 3D model viewer created & used for Revision 2021's 3D Graphics Competition.

grafik

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 force-pushed the init/foxotron-2021-03-12/21.05 branch from bdb14af to 1a63325 Compare April 8, 2021 12:58
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Apr 8, 2021

Fixed building on Darwin but binary fails to launch for me, marking as broken on Darwin.

Open STUB
[GLFW] Version String: 3.4.0 Cocoa NSGL EGL OSMesa
NSGL: Failed to find a suitable pixel format
[GLFW] Window creation failed
Renderer::Open failed

@OPNA2608 OPNA2608 force-pushed the init/foxotron-2021-03-12/21.05 branch from 1a63325 to 6520a5f Compare April 8, 2021 13:06
@OPNA2608
Copy link
Contributor Author

NSGL: Failed to find a suitable pixel format

Looking at glew (package builds a static version), maybe adding OpenGL on Darwin would help?

@OPNA2608 OPNA2608 force-pushed the init/foxotron-2021-03-12/21.05 branch from 6520a5f to 17d2de3 Compare April 16, 2021 18:34
@OPNA2608 OPNA2608 force-pushed the init/foxotron-2021-03-12/21.05 branch from 17d2de3 to 66be556 Compare April 16, 2021 18:39
@OPNA2608
Copy link
Contributor Author

I think it should run on an actual x86_64-darwin machine. 🤷‍♂️

@SuperSandro2000
Copy link
Member

It doesn't crash on darwin.

@SuperSandro2000 SuperSandro2000 merged commit c756aa9 into NixOS:master Apr 17, 2021
@OPNA2608 OPNA2608 deleted the init/foxotron-2021-03-12/21.05 branch September 27, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants