Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Fix the build (libva redefinition) #119003

Merged
merged 1 commit into from Apr 10, 2021
Merged

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 10, 2021

The recent libva 2.11.0 update (780fa55) broke the chromium and
ungoogled-chromium builds. Fix #118931.


Actual source: kiss-community/community#252

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The recent libva 2.11.0 update (780fa55) broke the chromium and
ungoogled-chromium builds. Fix NixOS#118931.
@primeos
Copy link
Member Author

primeos commented Apr 10, 2021

Note: This is still untested. On my test setup it'll take 10-12h to test so help is welcome. There are also other options, see #118931.

@flokli
Copy link
Contributor

flokli commented Apr 10, 2021

I just kicked off a build, will report back.

@sternenseemann
Copy link
Member

sternenseemann commented Apr 10, 2021

I just kicked off a build, will report back.

Reporting back for @flokli, the build has apparently finished successfully:

$ nix-store --realise /nix/store/27m0db53d2sq1pn4fs3d23fclb7c87hd-chromium-89.0.4389.114.drv
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/9gfcmn7pqwdhjwcl6jilkmwm7iw8yd28-chromium-89.0.4389.114-sandbox
/nix/store/mmrzrwnn7974px169c2kw7jryphsmmri-chromium-89.0.4389.114

@primeos
Copy link
Member Author

primeos commented Apr 10, 2021

Great, thanks a lot to both of you! Let's merge this then :)

@primeos primeos merged commit 4b9e672 into NixOS:master Apr 10, 2021
@mweinelt
Copy link
Member

/nix/store/6kxlap6bkhhzgzx42f3flfqbx6n08bz8-vm-test-run-chromium-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chromium fails to build on nixpkgs master
4 participants