Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcpdump: 4.9.3 -> 4.99.0 #119005

Merged
merged 1 commit into from Apr 11, 2021
Merged

tcpdump: 4.9.3 -> 4.99.0 #119005

merged 1 commit into from Apr 11, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

8 packages built:
  • compactor
  • evillimiter
  • firehol
  • home-assistant
  • john
  • python38Packages.scapy
  • python39Packages.scapy
  • tcpdump

@veprbl
Copy link
Member

veprbl commented Apr 10, 2021

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from globin April 10, 2021 11:28
@LeSuisse LeSuisse changed the title tcpdump: 4.9.3 -> 4.9.99 tcpdump: 4.9.3 -> 4.99.0 Apr 10, 2021
@Ma27 Ma27 merged commit 7e736eb into NixOS:master Apr 11, 2021
@LeSuisse LeSuisse deleted the tcpdump-4.9.99 branch April 11, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@vcunat vcunat vcunat left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LeSuisse @veprbl @mweinelt @vcunat @SuperSandro2000 @Ma27