Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyeconet: init at 0.1.13 #119083

Merged
merged 3 commits into from Apr 11, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 10, 2021

Motivation for this change

Python interface to the EcoNet API

https://github.com/w1ll1am23/pyeconet

This is a Home assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff

This comment has been minimized.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 10, 2021

Result of nixpkgs-review pr 119083 at 27b43667 run on aarch64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.pyeconet
  • python39Packages.pyeconet
3 suggestions:
  • warning: unused-argument

    Unused argument: pytestCheckHook.
    Near pkgs/development/python-modules/pyeconet/default.nix:5:3:

      |
    5 | , pytestCheckHook
      |   ^
    
  • warning: unused-argument

    Unused argument: mock.
    Near pkgs/development/python-modules/pyeconet/default.nix:8:3:

      |
    8 | , mock
      |   ^
    
  • warning: unused-argument

    Unused argument: pythonOlder.
    Near pkgs/development/python-modules/pyeconet/default.nix:6:3:

      |
    6 | , pythonOlder
      |   ^
    

Result of nixpkgs-review pr 119083 at 27b43667 run on x86_64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.pyeconet
  • python39Packages.pyeconet
3 suggestions:
  • warning: unused-argument

    Unused argument: pythonOlder.
    Near pkgs/development/python-modules/pyeconet/default.nix:6:3:

      |
    6 | , pythonOlder
      |   ^
    
  • warning: unused-argument

    Unused argument: pytestCheckHook.
    Near pkgs/development/python-modules/pyeconet/default.nix:5:3:

      |
    5 | , pytestCheckHook
      |   ^
    
  • warning: unused-argument

    Unused argument: mock.
    Near pkgs/development/python-modules/pyeconet/default.nix:8:3:

      |
    8 | , mock
      |   ^
    

@mweinelt mweinelt merged commit 3d460fa into NixOS:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants