python3Packages.pycomfoconnect: init at 0.4

[fabaff]

Motivation for this change

Python module to interact with ComfoAir Q350/450/600 units

https://github.com/michaelarnauts/comfoconnect

This is Home Assistant dependency.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[fabaff]

Result of nixpkgs-review pr 119126 run on x86_64-linux 1

3 packages built:

• home-assistant
• python38Packages.pycomfoconnect
• python39Packages.pycomfoconnect

[r-rmcgibbo]

Result of nixpkgs-review pr 119126 at e9a0be7 run on aarch64-linux 1

3 packages built successfully:

• home-assistant
• python38Packages.pycomfoconnect
• python39Packages.pycomfoconnect

1 suggestion:

• warning: unused-argument

  Unused argument: pytestCheckHook.
  Near pkgs/development/python-modules/pycomfoconnect/default.nix:5:3:

    |
  5 | , pytestCheckHook
    |   ^
  

---

Result of nixpkgs-review pr 119126 at e9a0be7 run on x86_64-linux 1

3 packages built successfully:

• home-assistant
• python38Packages.pycomfoconnect
• python39Packages.pycomfoconnect

1 suggestion:

• warning: unused-argument

  Unused argument: pytestCheckHook.
  Near pkgs/development/python-modules/pycomfoconnect/default.nix:5:3:

    |
  5 | , pytestCheckHook
    |   ^
  

[SuperSandro2000]

Suggested change

, pytestCheckHook

[mweinelt]

@fabaff?

[Mic92]

Result of nixpkgs-review pr 119126 run on x86_64-linux 1

1 package failed to build:

• home-assistant

2 packages built:

• python38Packages.pycomfoconnect
• python39Packages.pycomfoconnect

[Mic92]

/nix/store/3a9vs2wy4mqfjy0svvy3m8ddmpryv5hc-python3.8-pywemo-0.6.4.drv failed for home-assistant so it might be unrelated.

[mweinelt]

Hm, ofBorg also transiently was unhappy about pywemo in #116256, but I could never reproduced that, neither on x86_64 nor on aarch64. Can you get a log? @Mic92

[Mic92]

@mweinelt https://p.krebsco.de/18z0khc

[mweinelt]

Right, somewhat racy sqlite queries. Let's disable that test and move on.

[mweinelt]

https://github.com/NixOS/nixpkgs/pull/119126/files#r611199763

Unaddressed review comment right here.