Revert "nixos/home-assistant: use override before overridePythonAttrs"

[mweinelt]

Reverts #118719

This breaks patching the package, overriding is a mess.

[dotlambda]

This shouldn't use overridePythonAttrs because that breaks the override that occurs later.

[sweber83]

@mweinelt
I agree with @dotlambda, overriding the default package with overridePythonAttrs already proved problematic here:
f9bd8b1
I think we should use overrideAttrs instead, like you did initially:
1050f14

[mweinelt]

So is the idea to revert f9bd8b1 as well?

[mweinelt]

Apparently this also disabled checkPhase on the nixos test.

https://logs.nix.ci/?key=nixos/nixpkgs.119276&attempt_id=cc9ad186-b19c-4ab8-b7cf-790ba45949e0

[sweber83]

@mweinelt
I don't really know much about the home assistant nixos tests.
Do I understand correctly, that the package tests (which we want to disable) run as part of the nixos tests, which are used to test the home assistant nixos module inside a vm?
So we count on the modules default package to have the tests enabled?

[dotlambda]

Apparently this also disabled checkPhase on the nixos test.

I don't think that's a problem, but we can override the package we use for the test.

[mweinelt]

So we count on the modules default package to have the tests enabled?

No, the other way around. The module package has them disabled by default, if you just pass pkgs.home-assistant, like the test does, they'll be enabled.

[mweinelt]

@dotlambda @sweber83 Is the state of this pr okay? I added another revert.