New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vim plugins #119235
Add vim plugins #119235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the last 3 commits into one.
Result of 25 packages built successfully:
2 suggestions:
|
Puuh. I've never squashed git commits before. I'm a little embarrassed how long it took 😅 But it's done now. |
I also added another plugin playground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- diff looks good
@hoppla20 please resolve the merge conflicts. |
I also removed a package that was in there twice. And I also added some other packages 😅 |
@hoppla20 and some more merge conflicts to resolve. Also please remove the merge commits. |
Like this or should I also remove 487d291314b8046cf8037d8ffdd87dd2e6b7b0ef |
Okay I rebased with the current changes on master. Does this branch look okay now? |
Motivation for this change
Adding Vim Plugins
I followed the following documentation for adding the plugins. I also added the plugins to my vim configuration and did some testing with each plugin. Do I have to do more tests/checks or is this okay for vim plugins?
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)