Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim plugins #119235

Merged
merged 8 commits into from Apr 25, 2021
Merged

Add vim plugins #119235

merged 8 commits into from Apr 25, 2021

Conversation

hoppla20
Copy link
Contributor

@hoppla20 hoppla20 commented Apr 12, 2021

Motivation for this change

Adding Vim Plugins

I followed the following documentation for adding the plugins. I also added the plugins to my vim configuration and did some testing with each plugin. Do I have to do more tests/checks or is this okay for vim plugins?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hoppla20 hoppla20 marked this pull request as ready for review April 12, 2021 16:07
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the last 3 commits into one.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119235 at ee74b8ed run on x86_64-linux 1

25 packages built successfully:
  • spacevim
  • vimPlugins.LeaderF
  • vimPlugins.ale
  • vimPlugins.chadtree
  • vimPlugins.coc-explorer
  • vimPlugins.compe-tabnine
  • vimPlugins.deol-nvim
  • vimPlugins.git-blame-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.lf-vim
  • vimPlugins.lualine-nvim
  • vimPlugins.nvim-compe
  • vimPlugins.nvim-dap
  • vimPlugins.registers-nvim
  • vimPlugins.rust-tools-nvim
  • vimPlugins.suda-vim
  • vimPlugins.vim-android
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-lsp
  • vimPlugins.vim-matchup
  • vimPlugins.vim-rooter
  • vimPlugins.vim-snippets
  • vimPlugins.vim-terraform-completion
  • vimPlugins.vimspector
  • vimPlugins.wildfire-vim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

@hoppla20
Copy link
Contributor Author

Puuh. I've never squashed git commits before. I'm a little embarrassed how long it took 😅 But it's done now.

@hoppla20
Copy link
Contributor Author

I also added another plugin playground

Copy link
Contributor

@roosemberth roosemberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • diff looks good

@SuperSandro2000
Copy link
Member

@hoppla20 please resolve the merge conflicts.

@hoppla20
Copy link
Contributor Author

I also removed a package that was in there twice. And I also added some other packages 😅

@SuperSandro2000
Copy link
Member

@hoppla20 and some more merge conflicts to resolve. Also please remove the merge commits.

@hoppla20
Copy link
Contributor Author

Like this or should I also remove 487d291314b8046cf8037d8ffdd87dd2e6b7b0ef

@hoppla20
Copy link
Contributor Author

Okay I rebased with the current changes on master. Does this branch look okay now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants