buildRustPackage: Provide overrideAttrs #119332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calls to `overrideAttrs` applied to the wrapped `mkDerivation` call, and overriding calls to `buildRustPackage` thus wasn't possible.
danieldk
reviewed
Apr 13, 2021
| platforms = rustc.meta.platforms; | ||
| } // meta; | ||
| }) | ||
| self = |
There was a problem hiding this comment.
This change would definitely make overrideAttrs more intuitive.
I wonder if it wouldn't be nicer to do this in make-rust-platform.nix. Doesn't destroy git blame and avoids having weird non-canonical formatting for Nix implementation details here.
Also, this would be an API change, since someone may rely on the existing behavior, so this change should be documented in the release notes.
|
This has been discussed a few times: #46842, NixOS/rfcs#67 AIUI this is currently stuck in RFC. |
|
@alyssais I see. Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously, calls to
overrideAttrsapplied to the wrappedmkDerivationcall, and overriding calls tobuildRustPackagethus wasn't possible.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)