Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pykmtronic: 0.0.3 -> 0.3.0 #119470

Merged
merged 1 commit into from May 5, 2021
Merged

python3Packages.pykmtronic: 0.0.3 -> 0.3.0 #119470

merged 1 commit into from May 5, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 14, 2021

Motivation for this change

Update to latest upstream release 0.3.0

Change log: https://github.com/dgomes/pykmtronic/releases/tag/0.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff marked this pull request as draft April 14, 2021 22:45
@fabaff
Copy link
Member Author

fabaff commented Apr 14, 2021

Home Assistant tests fail.

@mweinelt
Copy link
Member

mweinelt commented Apr 14, 2021 •
edited

Home Assistant tests fail.

How.

API Changes. home-assistant/core@e4a7260

mweinelt
mweinelt requested changes Apr 14, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin 0.0.3 in home-assistant.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 14, 2021 •
edited

Result of nixpkgs-review pr 119470 at 604e28cb run on aarch64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.pykmtronic
  • python39Packages.pykmtronic

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 119470 at 604e28cb run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.pykmtronic
  • python39Packages.pykmtronic

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@fabaff
Copy link
Member Author

fabaff commented Apr 26, 2021

home-assistant/core#49191 was merged. pykmtroni-0.3.0will be used for 2015.5.x.

@fabaff fabaff marked this pull request as ready for review May 3, 2021 20:19
@mweinelt mweinelt added this to To do in Home Assistant via automation May 4, 2021
@mweinelt mweinelt moved this from To do to Reviewed in Home Assistant May 4, 2021
@mweinelt mweinelt merged commit 0b2495c into NixOS:master May 5, 2021
Home Assistant automation moved this from Reviewed to Done May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
Home Assistant
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @mweinelt @r-rmcgibbo