Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pywemo: fix tests #119882

Merged
merged 1 commit into from Apr 20, 2021
Merged

python3Packages.pywemo: fix tests #119882

merged 1 commit into from Apr 20, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

Testdriving pywemo/pywemo#264.

Adds a patch that flushes the db, before relying on it during further
tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
python3Packages.pywemo: fix tests
eaab528 
Adds a patch that flushes the db, before relying on it during further
tests.
@mweinelt mweinelt requested review from Mic92 and fabaff April 19, 2021 17:02
@mweinelt
Copy link
Member Author

Needs more people to build it, the test is flaky and could just by shy.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on
a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 119882 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.pywemo
  • python39Packages.pywemo

build two times and seems to work

@fabaff
Copy link
Member

fabaff commented Apr 19, 2021

Result of nixpkgs-review pr 119882 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.pywemo
  • python39Packages.pywemo

fabaff
fabaff approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally I never hit that issue.

@Mic92 Mic92 merged commit b0d0d6b into NixOS:master Apr 20, 2021
@Mic92
Copy link
Member

Mic92 commented Apr 20, 2021

Also worked for me.

@mweinelt mweinelt deleted the python/pywemo branch April 20, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @SuperSandro2000 @fabaff @Mic92