Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.30 -> 1.32.2 #119981

Merged
merged 4 commits into from Apr 23, 2021
Merged

matrix-synapse: 1.30 -> 1.32.2 #119981

merged 4 commits into from Apr 23, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 20, 2021

Motivation for this change

Closes #118864

https://github.com/matrix-org/synapse/releases/tag/v1.31.0
https://github.com/matrix-org/synapse/releases/tag/v1.32.0
https://github.com/matrix-org/synapse/releases/tag/v1.32.1
https://github.com/matrix-org/synapse/releases/tag/v1.32.2

Note: from this release onwards at least Postgres 9.6 and Python 3.6 is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

WARNING: We've identified a load issue with Prometheus metrics in this release; we encourage you to wait for 1.32.1 which should be published tomorrow (April 21st).

@Ma27
Copy link
Member Author

Ma27 commented Apr 20, 2021

Yeah, didn't intend to merge it tonight :)

@ajs124 ajs124 mentioned this pull request Apr 20, 2021
10 tasks
@Ma27 Ma27 changed the title matrix-synapse: 1.30 -> 1.32 matrix-synapse: 1.30 -> 1.32.1 Apr 21, 2021
@sumnerevans
Copy link
Member

https://github.com/matrix-org/synapse/blob/develop/CHANGES.md

This release fixes a regression in Synapse 1.32.0 that caused connected Prometheus instances to become unstable.

However, as this release is still subject to the LoggingContext change in 1.32.0, it is recommended to remain on or downgrade to 1.31.0.

@Ma27
Copy link
Member Author

Ma27 commented Apr 21, 2021

Thanks for noticing, apparently this was realized after my latest update here :)

Wondering if applying matrix-org/synapse@d9bd62f would be sufficient here.

@Ma27 Ma27 changed the title matrix-synapse: 1.30 -> 1.32.1 matrix-synapse: 1.30 -> 1.32.2 Apr 22, 2021
@Ma27
Copy link
Member Author

Ma27 commented Apr 22, 2021

1.32.2 is out. Seems to fix the problem. Just deployed it to my instance and it seems fine.

@Ma27 Ma27 merged commit dd550dd into NixOS:master Apr 23, 2021
@Ma27 Ma27 deleted the bump-matrix-synapse branch April 23, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants