Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: add version 1.76 #120132

Closed
wants to merge 1 commit into from
Closed

boost: add version 1.76 #120132

wants to merge 1 commit into from

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Apr 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines +8 to +11
"mirror://sourceforge/boost/boost_1_76_0.tar.bz2"
"https://dl.bintray.com/boostorg/release/1.76.0/source/boost_1_76_0.tar.bz2"
];
# SHA256 from http://www.boost.org/users/history/version_1_76_0.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those version numbers not substituted?

Copy link
Member Author

@hjones2199 hjones2199 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because nixpkgs carries every version of boost starting with 1.55, the version-specific files aren't generalized since they are effectively "pinned" forever.

Copy link
Member Author

@hjones2199 hjones2199 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to start fetching from https://github.com/boostorg/boost/releases instead of their sourceforge mirrors? Also i'm not sure why nixpkgs "default boost" is still 1.6. I can try to bump it, but this PR will need to go to staging or staging-next for that since it will be the mother of all mass rebuilds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to start fetching from boostorg/boost/releases instead of their sourceforge mirrors?

I think that is a good idea for new releases. It also makes fetching patches easier.

Also i'm not sure why nixpkgs "default boost" is still 1.6.

Probably because many packages break if we change it.

this PR will need to go to staging

It will be staging and that is not a problem.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 120132 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • gnuradio3_7Packages.ais
  • gnuradio3_7Packages.gsm
  • gnuradio3_7Packages.osmosdr
2 packages failed to build and already failed to build on hydra master:
  • rippled: log was empty
  • rippled-validator-keys-tool: log was empty
25 packages failed to build and are new build failures:
  • cubicsdr: log was empty
  • gnss-sdr: log was empty
  • gnuradio: log was empty
  • gnuradio3_8: log was empty
  • gnuradio3_8Minimal: log was empty
  • gnuradio3_8Packages.gnuradio: log was empty
  • gnuradio3_8Packages.limesdr: log was empty
  • gnuradio3_8Packages.osmosdr: log was empty
  • gnuradio3_8Packages.rds: log was empty
  • gnuradioMinimal: log was empty
  • gnuradioPackages.gnuradio: log was empty
  • gqrx: log was empty
  • inspectrum: log was empty
  • monero: log was empty
  • monero-gui: log was empty
  • pothos: log was empty
  • python38Packages.soapysdr-with-plugins: log was empty
  • python39Packages.soapysdr-with-plugins: log was empty
  • qradiolink: log was empty
  • rtl_433: log was empty
  • sdrangel: log was empty
  • soapysdr-with-plugins: log was empty
  • soapyuhd: log was empty
  • uhd: log was empty
  • welle-io: log was empty
8 packages built:
  • boost176 (boost17x)
  • colmap
  • colmapWithCuda
  • ifcopenshell (python38Packages.ifcopenshell)
  • mtxclient
  • nheko
  • python39Packages.ifcopenshell
  • qmediathekview

@hjones2199 hjones2199 marked this pull request as draft April 22, 2021 15:40
@fgaz
Copy link
Member

fgaz commented May 24, 2021

Any progress on this? I have a (new) package that needs 1.76

@hjones2199
Copy link
Member Author

Any progress on this? I have a (new) package that needs 1.76

Wanting to get #120259 merged first, then rework this to fit the more standardized boost version format

@nagy
Copy link
Member

nagy commented Aug 17, 2021

Boost 1.77 has since been released. Maybe we can skip 1.76 altogether and jump directly to 1.77 .

https://www.boost.org/users/history/version_1_77_0.html

@hjones2199
Copy link
Member Author

Superseded by #138309, since boost changes are going to trigger mass rebuilds I consolidated the addition of boost 1.77 with bumping the default boost version.

@hjones2199 hjones2199 closed this Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants