-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add version 1.76 #120132
boost: add version 1.76 #120132
Conversation
"mirror://sourceforge/boost/boost_1_76_0.tar.bz2" | ||
"https://dl.bintray.com/boostorg/release/1.76.0/source/boost_1_76_0.tar.bz2" | ||
]; | ||
# SHA256 from http://www.boost.org/users/history/version_1_76_0.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those version numbers not substituted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because nixpkgs carries every version of boost starting with 1.55, the version-specific files aren't generalized since they are effectively "pinned" forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be better to start fetching from https://github.com/boostorg/boost/releases instead of their sourceforge mirrors? Also i'm not sure why nixpkgs "default boost" is still 1.6. I can try to bump it, but this PR will need to go to staging or staging-next for that since it will be the mother of all mass rebuilds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be better to start fetching from boostorg/boost/releases instead of their sourceforge mirrors?
I think that is a good idea for new releases. It also makes fetching patches easier.
Also i'm not sure why nixpkgs "default boost" is still 1.6.
Probably because many packages break if we change it.
this PR will need to go to staging
It will be staging and that is not a problem.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages marked as broken and skipped:
2 packages failed to build and already failed to build on hydra master:
25 packages failed to build and are new build failures:
8 packages built:
|
Any progress on this? I have a (new) package that needs 1.76 |
Wanting to get #120259 merged first, then rework this to fit the more standardized boost version format |
Boost 1.77 has since been released. Maybe we can skip 1.76 altogether and jump directly to 1.77 . |
Superseded by #138309, since boost changes are going to trigger mass rebuilds I consolidated the addition of boost 1.77 with bumping the default boost version. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)