Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bettercap: 2.30.2 -> 2.31.0 #120150

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bettercap/bettercap/releases.

meta.description for bettercap is: "A man in the middle tool"

meta.homepage for bettercap is: "https://www.bettercap.org/"

meta.changelog for bettercap is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0/bin/bettercap passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 2.31.0 with grep in /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0

  • found 2.31.0 in filename of file in /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0

  • directory tree listing: https://gist.github.com/0b1b740d56b9882781b64f5d93443b0b

  • du listing: https://gist.github.com/f9047f111a764536d296c637db57402e


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
bettercap
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A bettercap https://github.com/r-ryantm/nixpkgs/archive/6d918cad3943b25f1dcccc668cc1e03a70e52faa.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0
ls -la /nix/store/bmyr56fdyd6airjyyz43r2x74ir4xg3s-bettercap-2.31.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • bettercap

Maintainer pings

cc @y0no @kalbasit for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120150 at 6d918ca run on x86_64-linux 1

1 package built successfully:
  • bettercap
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/security/bettercap/default.nix:36:5:

       |
    36 |     license = with licenses; gpl3;
       |     ^
    

Result of nixpkgs-review pr 120150 at 6d918ca run on aarch64-linux 1

1 package built successfully:
  • bettercap

@fabaff
Copy link
Member

fabaff commented Apr 22, 2021

Result of nixpkgs-review pr 120150 run on x86_64-linux 1

1 package built:
  • bettercap

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-120150]$ sudo ./results/bettercap/bin/bettercap 
bettercap v2.31.0 (built for linux amd64 with go1.16.3) [type 'help' for a list of commands]

192.168.1.0/24 > 192.168.1.197  » [11:03:46] [sys.log] [inf] gateway monitor started ...
192.168.1.0/24 > 192.168.1.197  » caplets.update
[11:05:09] [sys.log] [inf] caplets creating caplets install path /usr/local/share/bettercap/ ...
[11:05:09] [sys.log] [inf] caplets downloading caplets from https://github.com/bettercap/caplets/archive/master.zip ...
[11:05:10] [sys.log] [inf] caplets installing caplets to /usr/local/share/bettercap/caplets ...
192.168.1.0/24 > 192.168.1.197  » net.show

┌───────────────┬───────────────────┬─────────┬─────────────────────────────────┬────────┬────────┬──────────┐
│     IP ▴      │        MAC        │  Name   │             Vendor              │  Sent  │ Recvd  │   Seen   │
├───────────────┼───────────────────┼─────────┼─────────────────────────────────┼────────┼────────┼──────────┤
│ 192.168.1. 2  │ 52:54:54:54:54:54 │ enp1s0  │ Realtek (UpTech? also reported) │ 0 B    │ 0 B    │ 11:03:46 │
│ 192.168.1.1   │ cd:cd:cd:cd:cd:cd │ gateway │ Belkin International Inc.       │ 4.6 kB │ 2.0 kB │ 11:03:46 │
│               │                   │         │                                 │        │        │          │
└───────────────┴───────────────────┴─────────┴─────────────────────────────────┴────────┴────────┴──────────┘

↑ 0 B / ↓ 87 kB / 451 pkts                            

Change looks good to me.

@fabaff fabaff merged commit c312d8b into NixOS:master Apr 23, 2021
@r-ryantm r-ryantm deleted the auto-update/bettercap branch April 25, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants