[staging-next] python3Packages.keyring: disable keychain tests on darwin #120206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
changed the title
dotlambda
reviewed
Apr 22, 2021
It is highly unlikely that we can communicate with keychain in our build environment. The tests were only recently enabled and have blocked this package ever since.
mweinelt
force-pushed
the
python/keyring
branch
from
b953d97
to
8967e3c
Compare
|
I think this can go to master. I did not build all depending packages though. |
|
/rebase master |
|
Never mind, the commit which broke it is not in master. |
|
Unfortunately it's still failing on Hydra: https://hydra.nixos.org/build/141759604 |
|
Are you sure that was already in by the time? The |
|
Yes, Hydra shows it's commit de5555d. |
|
I'm suspicious of the |
mweinelt
commented
Apr 22, 2021
| "test_multiprocess_get_after_native_get" | ||
| ]; | ||
|
|
||
| disabledTestsPaths = [ |
There was a problem hiding this comment.
Uh, typo.
Tests -> Test.
There was a problem hiding this comment.
I'll push a fix to staging-next.
|
Fixed in 26dbd04. |
|
A way of testing smaller x86_64-darwin builds would be nice, again a machine for OfBorg or someone writing up a GitHub action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is highly unlikely that we can communicate with keychain in our build
environment. The tests were only recently enabled and have blocked this
package ever since.
Motivation for this change
https://nix-cache.s3.amazonaws.com/log/dj4appp2b8qq2vlakg6sgr218ky71ff4-python3.8-keyring-23.0.1.drv
Needs to be tested on x86_64-darwin
#119398
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)