snapper: 0.8.15 -> 0.9.0

[markuskowa]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[legendofmiracles]

Result of nixpkgs-review pr 120210 run on x86_64-linux 1

2 packages built:

• snapper
• snapper-gui

[r-rmcgibbo]

Result of nixpkgs-review pr 120210 at eec1bf4b run on x86_64-linux 1

2 packages built successfully:

• snapper
• snapper-gui

14 suggestions:

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '/usr' doesn't match anything in file 'data/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: build-tools-in-build-inputs

  util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/misc/snapper/default.nix:22:3:

     |
  22 |   buildInputs = [
     |   ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '$(DESTDIR)/usr' doesn't match anything in file 'client/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '/usr' doesn't match anything in file '/nix/store/wz6w2kmppspc5wksagj0jzqiq43502rz-snapper-0.9.0/lib/systemd/system/snapper-boot.timer'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '/usr' doesn't match anything in file '/nix/store/wz6w2kmppspc5wksagj0jzqiq43502rz-snapper-0.9.0/lib/systemd/system/snapper-timeline.timer'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '$(DESTDIR)/usr' doesn't match anything in file 'pam/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern 'DESTDIR' doesn't match anything in file 'pam/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '$(DESTDIR)/usr' doesn't match anything in file 'scripts/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern 'DESTDIR' doesn't match anything in file 'zypp-plugin/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '/usr' doesn't match anything in file '/nix/store/wz6w2kmppspc5wksagj0jzqiq43502rz-snapper-0.9.0/lib/systemd/system/snapper-cleanup.timer'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/tools/misc/snapper/default.nix:4:34:

    |
  4 | , lvm2, pam, python, util-linux, fetchpatch, json_c, nixosTests
    |                                  ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '/usr' doesn't match anything in file 'pam/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern 'DESTDIR' doesn't match anything in file 'client/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

• warning: stale-substitute

  Stale substituteInPlace detected.
  substituteStream(): WARNING: pattern '$(DESTDIR)/usr' doesn't match anything in file 'zypp-plugin/Makefile.am'
  Near pkgs/tools/misc/snapper/default.nix:62:0:

     |
  62 |     description = "Tool for Linux filesystem snapshot management";
     | ^
  

---

Result of nixpkgs-review pr 120210 at eec1bf4b run on aarch64-linux 1

2 packages built successfully:

• snapper
• snapper-gui

[markuskowa]

• Removed fetchpatch from inputs.
• Some substitutes are still needed. Trying to remove them one-by-one would actually lead to a more complex code.
• util-linux most likely belongs into buildInputs here.