Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecraft-launcher: 2.2.1441 -> 2.2.741 #120232

Merged
merged 1 commit into from Apr 22, 2021

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Launcher showed me a warning about it being outdated when launched, this fixed that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@robintown
Copy link
Contributor

I'm confused, isn't this an even older version of the launcher? Looking in the about section, it says it was built November 27, 2020, whereas the 2.2.1441 launcher says it was built January 27, 2021. The reason we're not using the latest version of the launcher, by the way, is #114732.

@ryantm
Copy link
Member

ryantm commented Apr 26, 2021

Dang. Sorry, I didn't look close enough at this.

@IvarWithoutBones
Copy link
Member Author

My sincere apologies, i had no idea. I just saw the version number go up, and the warning about updating disappear so I assumed it updated just fine.

Again, my apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants