Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidjson: make compatible with C++20 #120235

Merged
merged 1 commit into from Apr 24, 2021
Merged

Conversation

cmm
Copy link
Member

@cmm cmm commented Apr 22, 2021

(by stealing the relevant patch from Fedora)

Motivation for this change

upstream does not compile with C++20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(by stealing the relevant patch from Fedora)
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 120235 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.kalzium
  • python39Packages.google-cloud-bigquery
57 packages built:
  • arrow-cpp
  • ccls
  • clickhouse
  • discord-rpc
  • gawk-with-extensions
  • gawkextlib.json
  • geonkick
  • hal-hardware-analyzer
  • ja2-stracciatella
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.netflix
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-sftp
  • laminar
  • libsForQt5.kalzium (libsForQt515.kalzium ,plasma5Packages.kalzium)
  • libsForQt5.mapbox-gl-native (libsForQt515.mapbox-gl-native ,plasma5Packages.mapbox-gl-native)
  • libsForQt5.mapbox-gl-qml (libsForQt515.mapbox-gl-qml ,plasma5Packages.mapbox-gl-qml)
  • libsForQt512.mapbox-gl-native
  • libsForQt512.mapbox-gl-qml
  • libsForQt514.kalzium
  • libsForQt514.mapbox-gl-native
  • libsForQt514.mapbox-gl-qml
  • monero
  • monero-gui
  • mysql-workbench
  • openbabel (openbabel3)
  • pure-maps
  • python38Packages.awkward
  • python38Packages.datasets
  • python38Packages.google-cloud-bigquery
  • python38Packages.intake
  • python38Packages.openbabel-bindings
  • python38Packages.pyarrow
  • python38Packages.rdkit
  • python39Packages.datasets
  • python39Packages.intake
  • python39Packages.openbabel-bindings
  • python39Packages.pyarrow
  • python39Packages.rdkit
  • rapidjson
  • sortmerna
  • vowpal-wabbit
  • wownero
  • yuzu-ea
  • yuzu-mainline

@SuperSandro2000 SuperSandro2000 merged commit 3a6dd82 into NixOS:master Apr 24, 2021
@cmm cmm deleted the rapidjson-c++20 branch April 24, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants