Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.openerz-api: init at 0.1.0 #120262

Merged
merged 3 commits into from Apr 23, 2021
Merged

python3Packages.openerz-api: init at 0.1.0 #120262

merged 3 commits into from Apr 23, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 22, 2021

Motivation for this change

Python module to interact with the OpenERZ API

https://github.com/misialq/openerz-api

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff changed the title Openerz api python3Packages.openerz-api: init at 0.1.0 Apr 22, 2021
@fabaff
Copy link
Member Author

fabaff commented Apr 22, 2021

Result of nixpkgs-review pr 120262 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.openerz-api
  • python39Packages.openerz-api

@ofborg ofborg bot requested review from Mic92, mweinelt and globin April 22, 2021 20:34
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021 •
edited

Result of nixpkgs-review pr 120262 at ac7fc628 run on aarch64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.openerz-api
  • python39Packages.openerz-api

Result of nixpkgs-review pr 120262 at ac7fc628 run on x86_64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.openerz-api
  • python39Packages.openerz-api

@mweinelt
Copy link
Member

Please rebase.

SuperSandro2000
SuperSandro2000 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@ofborg ofborg bot requested a review from mweinelt April 23, 2021 07:25
@fabaff fabaff merged commit e097a35 into NixOS:master Apr 23, 2021
@fabaff fabaff deleted the openerz-api branch April 23, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @r-rmcgibbo @mweinelt @SuperSandro2000