Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; + deepmerge, sacn #120280

Merged
merged 4 commits into from Apr 28, 2021
Merged

python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; + deepmerge, sacn #120280

merged 4 commits into from Apr 28, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

Updates to python packages i maintain.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member Author

mweinelt commented Apr 23, 2021 •
edited

Not entirely sure what is wrong with that test, but at least it fails consistently.

https://github.com/agronholm/anyio/blob/3.0.0/tests/test_from_thread.py#L42-L56

agronholm/anyio#265

Can't repro on my rpi4.

@mweinelt

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member Author

@GrahamcOfBorg build python3Packages.anyio

@mweinelt
Copy link
Member Author

OfBorg can't repro anyio test errors either.

@SuperSandro2000

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member Author

Waiting for the anyio upstream, they acknowledged the assertion is bogus.

@fabaff
Copy link
Member

fabaff commented Apr 25, 2021

There was a new async_upnp_client release published.

@mweinelt
Copy link
Member Author

Updated. Disabled the flaky test in anyio.

@mweinelt
Copy link
Member Author

mweinelt commented Apr 28, 2021 •
edited

Dropped the anyio update from this change as it apparently broke jupyter_server. Moving to a dedicated pull request.

Result of nixpkgs-review pr 120280 run on x86_64-linux 1

19 packages built:
  • errbot
  • home-assistant
  • python38Packages.async-upnp-client
  • python38Packages.clldutils
  • python38Packages.deepmerge
  • python38Packages.openhomedevice
  • python38Packages.phonemizer
  • python38Packages.pyipp
  • python38Packages.sacn
  • python38Packages.segments
  • python39Packages.async-upnp-client
  • python39Packages.clldutils
  • python39Packages.deepmerge
  • python39Packages.openhomedevice
  • python39Packages.phonemizer
  • python39Packages.pyipp
  • python39Packages.sacn
  • python39Packages.segments
  • tts

@mweinelt mweinelt changed the title python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; python3Packages.anyio: 2.2.0 -> 3.0.0 python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; Apr 28, 2021
@mweinelt mweinelt changed the title python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; python3Packages.async-upnp-client: 0.16.0 -> 0.16.1; python3Packages.clldutils: 3.7.0 -> 3.8.0; + deepmerge, sacn Apr 28, 2021
@mweinelt mweinelt merged commit 8f40681 into NixOS:master Apr 28, 2021
@mweinelt mweinelt deleted the python/updates branch April 28, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @r-rmcgibbo @SuperSandro2000 @fabaff