Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sshguard: restart sshguard when services/backend changes #120324

Merged
merged 1 commit into from
Apr 23, 2021
Merged

nixos/sshguard: restart sshguard when services/backend changes #120324

merged 1 commit into from
Apr 23, 2021

Conversation

pennae
Copy link
Contributor

@pennae pennae commented Apr 23, 2021

backends changing shouldn't be very likely, but services may well change. we
should restart sshguard from nixos-rebuild instead of merely plopping down a new
config file and waiting for the user to restart sshguard.

Motivation for this change

fix #120282

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pennae
nixos/sshguard: restart sshguard when services/backend changes
265d31b 
backends changing shouldn't be very likely, but services may well change. we
should restart sshguard from nixos-rebuild instead of merely plopping down a new
config file and waiting for the user to restart sshguard.
@pennae pennae requested a review from aanderse April 23, 2021 20:42
aanderse
aanderse approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 You tested this revision, right?

@pennae
Copy link
Contributor Author

pennae commented Apr 23, 2021

LGTM +1 You tested this revision, right?

yup. (and retested just now, just to be sure.)

@aanderse
Copy link
Member

Thanks for your contribution.

@aanderse aanderse merged commit 5f2a8de into NixOS:master Apr 23, 2021
symphorien added a commit to symphorien/nixpkgs that referenced this pull request Apr 24, 2021
@symphorien
nixos/nagios: use the correct option to restart on config change
ddf567c 
X-ReloadIfChanged is incorrect, apparently NixOS#120324 (comment)
We restart instead of reloading because nagios unit file has no
ExecReload.
@symphorien symphorien mentioned this pull request Apr 24, 2021
Merged
10 tasks
@pennae pennae deleted the restart-sshguard branch May 1, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sshguard is not restarted when services.sshguard.services changes
2 participants
@pennae @aanderse