Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nagios: use the correct option to restart on config change #120537

Merged
merged 1 commit into from Apr 24, 2021

Conversation

symphorien
Copy link
Member

X-ReloadIfChanged is incorrect, apparently #120324 (comment)
We restart instead of reloading because nagios unit file has no ExecReload.

cc @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

X-ReloadIfChanged is incorrect, apparently NixOS#120324 (comment)
We restart instead of reloading because nagios unit file has no
ExecReload.
@aanderse
Copy link
Member

So you want to restart or reload? Generally you shouldn't reload on servers like this because you don't get system updates that way.

@symphorien
Copy link
Member Author

My point is: it does the same thing, since there is no ExecReload.

@aanderse
Copy link
Member

You can combine restartTriggers = [ ... ]; with reloadIfChanged = true;... but as mentioned I wouldn't suggest this for what we ship.

The scenario where this is useful would be when you automatically reboot your server every time you update your system but you want to avoid service restarts when you change configuration.

@symphorien
Copy link
Member Author

Then we agree that restarting is the way to go and that this change is the right one :)

@GrahamcOfBorg test nagios

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely 👍

@symphorien symphorien merged commit 1c62c0f into NixOS:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants