Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buck: use jdk8 #120559

Merged
merged 1 commit into from Apr 25, 2021
Merged

buck: use jdk8 #120559

merged 1 commit into from Apr 25, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 24, 2021

Motivation for this change

closes #120557

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

cc @HolgerPeters

@asbachb
Copy link
Contributor

asbachb commented Apr 24, 2021

I wonder if this PR is still needed for the most recent version: facebook/buck#2037

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 24, 2021

Result of nixpkgs-review pr 120559 at ad521d0 run on aarch64-linux 1

1 package built successfully:
  • buck
3 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/tools/build-managers/buck/default.nix:22:3:

       |
    22 |   buildPhase = ''
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/build-managers/buck/default.nix:14:15:

       |
    14 |   patches = [ ./pex-mtime.patch ];
       |               ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/build-managers/buck/default.nix:31:3:

       |
    31 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 120559 at ad521d0 run on x86_64-linux 1

1 package built successfully:
  • buck
3 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/build-managers/buck/default.nix:14:15:

       |
    14 |   patches = [ ./pex-mtime.patch ];
       |               ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/build-managers/buck/default.nix:31:3:

       |
    31 |   installPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/tools/build-managers/buck/default.nix:22:3:

       |
    22 |   buildPhase = ''
       |   ^
    

@jonringer
Copy link
Contributor Author

I wonder if this PR is still needed for the most recent version: facebook/buck#2037

last stable release was from January, those changes are from feburary.

#120557 (comment)

Until they make a stable release with those changes included, we will just use jdk8

@marsam marsam merged commit 4a1bad5 into NixOS:master Apr 25, 2021
@jonringer jonringer deleted the buck-jdk8 branch April 26, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buck built with wrong JDK version
5 participants