Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buck: use jdk8 #120559

Merged
merged 1 commit into from
Apr 25, 2021
Merged

buck: use jdk8 #120559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkgs/development/tools/build-managers/buck/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, stdenv, fetchFromGitHub, jdk11, ant, python3, watchman, bash, makeWrapper }:
{ lib, stdenv, fetchFromGitHub, jdk8, ant, python3, watchman, bash, makeWrapper }:

stdenv.mkDerivation rec {
pname = "buck";
Expand All @@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
grep -l -r '/bin/bash' --null | xargs -0 sed -i -e "s!/bin/bash!${bash}/bin/bash!g"
'';

nativeBuildInputs = [ makeWrapper python3 jdk11 ant watchman ];
nativeBuildInputs = [ makeWrapper python3 jdk8 ant watchman ];

buildPhase = ''
# Set correct version, see https://github.com/facebook/buck/issues/2607
Expand All @@ -31,7 +31,7 @@ stdenv.mkDerivation rec {
installPhase = ''
install -D -m755 buck-out/gen/*/programs/buck.pex $out/bin/buck
wrapProgram $out/bin/buck \
--prefix PATH : "${lib.makeBinPath [ jdk11 watchman python3 ]}"
--prefix PATH : "${lib.makeBinPath [ jdk8 watchman python3 ]}"
'';

meta = with lib; {
Expand Down