Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagelol: init at 0.2 #120659

Merged
merged 1 commit into from Apr 27, 2021
Merged

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

A really interesting package i would love to have available in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 25, 2021

Result of nixpkgs-review pr 120659 at 249d904 run on x86_64-linux 1

1 package built successfully:
  • imagelol
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/compression/imagelol/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 120659 at 249d904 run on aarch64-linux 1

1 package built successfully:
  • imagelol
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/compression/imagelol/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit 3be2b56 into NixOS:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants