Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: 5.11 -> 5.12 #120769

Merged
merged 1 commit into from Apr 27, 2021
Merged

strace: 5.11 -> 5.12 #120769

merged 1 commit into from Apr 27, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 26, 2021 •
edited

Motivation for this change

ChangeLog: https://github.com/strace/strace/releases/tag/v5.12

Added a 9.needs: port to stable label because new kernel minors get backported to stable and each strace release (including this one) adds support for e.g. newly added syscalls, so a new strace may be useful there as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 26, 2021
@ofborg ofborg bot requested a review from globin April 26, 2021 18:34
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021 •
edited

Result of nixpkgs-review pr 120769 at 86f1c0fb run on aarch64-linux 1

3 packages built successfully:
  • gcl_2_6_13_pre
  • libabigail
  • strace

Result of nixpkgs-review pr 120769 at 86f1c0fb run on x86_64-linux 1

1 package failed to build:
2 packages built successfully:
  • libabigail
  • strace

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

SuperSandro2000
SuperSandro2000 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@mweinelt mweinelt merged commit 8f284a9 into NixOS:master Apr 27, 2021
@Ma27 Ma27 deleted the strace-bump branch April 27, 2021 13:09
@Ma27
Copy link
Member Author

Ma27 commented Apr 27, 2021

@mweinelt would you mind taking care of the backport :)

@mweinelt mweinelt mentioned this pull request Apr 27, 2021
Merged
10 tasks
@mweinelt mweinelt added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @r-rmcgibbo @mweinelt @SuperSandro2000