Fix grab-site and python3Packages.lmdb #120785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes no sense and yet was added in 65eccfa This was breaking the build of python3Packages.lmdb because ludios_wpull does not build on 3.8, only 3.7.
This has a fix for https://bugs.openldap.org/show_bug.cgi?id=9461, thus fixing pythonPackages.lmdb: jnwatson/py-lmdb#278
|
The C part looks good to me; I'm not really familiar with the python package. |
|
@ofborg build python3.pkgs.lmdb |
lukegb
approved these changes
Apr 26, 2021
|
Result of 61 packages marked as broken and skipped:
1 package failed to build:48 packages skipped due to time constraints:
44 packages built successfully:
2 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
|
On Mon, Apr 26, 2021 at 07:57:58PM +0000, Ivan Kozik wrote:
This makes no sense and yet was added in 65eccfa
This was breaking the build of python3Packages.lmdb because ludios_wpull does not
build on 3.8, only 3.7
- propogatedBuildInputs = [ ludios_wpull ];
-
weird, good catch. ACK.
|
| @@ -2,12 +2,12 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| pname = "lmdb"; | |||
| version = "0.9.28"; | |||
| version = "0.9.29"; | |||
|
|
|||
| src = fetchgit { | |||
There was a problem hiding this comment.
This could be converted to fetchFromGitLab.
There was a problem hiding this comment.
Sure, but I hope that doesn't need to hold this up
There was a problem hiding this comment.
Also please update the homepage to https://symas.com/lmdb/technical/
mweinelt
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc maintainers @copumpkin @jb55 @vcunat
I confirmed that grab-site now builds and runs on NixOS master.