Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: init at 1.5.19 #121009

Closed
wants to merge 1 commit into from
Closed

solana: init at 1.5.19 #121009

wants to merge 1 commit into from

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Apr 28, 2021

This adds Solana, a performance-oriented blockchain. The source is the Solana monorepo, which includes the development tools and tools needed to interact with the network.

Version 1.5.19 is not the latest release at the time of writing, but it is the latest one intended for use with the mainnet.

Motivation for this change
  • Having the Solana devtools available in Nixpkgs makes it easy to manage development environments with Nix.
  • Solana users who also use Nix don’t need to download a binary / manually build from source any more.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines 43 to 49
LLVM_CONFIG_PATH = "${llvm}/bin/llvm-config";
LIBCLANG_PATH = "${llvmPackages.libclang}/lib";

# Used by build.rs in the rocksdb-sys crate. If we don't set these, it would
# try to build RocksDB from source.
ROCKSDB_INCLUDE_DIR = "${rocksdb}/include";
ROCKSDB_LIB_DIR = "${rocksdb}/lib";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we export those in preBuild?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Note that this PR is a work in progress, the Rust binaries build now, but the cargo-bpf tools refer to the BPF SDK which is not yet packaged. (Upstream there’s a script that downloads prebuilt binaries from GitHub, the binaries include a patched Rust + LLVM toolchain.)

This adds Solana, a performance-oriented blockchain. The source is from
the Solana monorepo, which includes the development tools and tools
needed to interact with the network.

Version 1.5.19 is not the latest release at the time of writing, but it
is the latest one intended for use with the mainnet.
@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2021
@ruuda ruuda mentioned this pull request Jan 6, 2022
13 tasks
@rollschild
Copy link

Hi, has there been any progress on this recently?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2022
@0xperp 0xperp mentioned this pull request Sep 5, 2022
13 tasks
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 2, 2022
@NickCao
Copy link
Member

NickCao commented Jan 26, 2023

superseded by later PRs.

@NickCao NickCao closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants