Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpiplay #121117

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Rpiplay #121117

merged 3 commits into from
Aug 21, 2021

Conversation

feijoas
Copy link
Contributor

@feijoas feijoas commented Apr 29, 2021

Motivation for this change

Added new package RPiPlay.
It is an open-source implementation of an AirPlay mirroring server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121117 at 70c30643 run on x86_64-linux 1

1 package built successfully:
  • rpiplay
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/servers/rpiplay/default.nix:15:5:

       |
    15 |     (fetchpatch {
       |     ^
    

pkgs/servers/rpiplay/default.nix Outdated Show resolved Hide resolved
pkgs/servers/rpiplay/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit ffac945 into NixOS:master Aug 21, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants