New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox-esr: use latest Rust #121290
firefox-esr: use latest Rust #121290
Conversation
Firefox ESR 78.x used to have a problem with Rust >= 1.46, but it works with latest Rust now!
Upstream confirmation: https://bugzilla.mozilla.org/show_bug.cgi?id=1663715#c14 I'll re-test the same with thunderbird and file a PR. |
FWIW: I did a testbuild (x86_64-linux) and did a cursory check of functionality. |
Should have said so, I'm already on it. There are some changes needed as the latest thunderbird release does not include the changes from Firefox ESR (yet) that allow it to build. |
Oh, OK. I didn't expect them to be "behind". |
Sooo... It's not that easy. It fails because of an old version of packed_simd, which references stuff that was removed from the standard library (because the underlying LLVM feature was removed). However, the Firefox source code also has this dependency, but it seemingly doesn't attempt to compile it. I found an upstream commit upgrading the dependency, but I'm not sure if it will get ported to the ESR branch. I can't really find the source repository for the ESR branch and Thunderbird anywhere, so it's a bit hard to see what will go into the next release. |
I can't see a problem in keeping thunderbird as it is. |
Well, it would be nice to remove rust_1_45 at some point to save some bytes and build time. Anyways, I found the difference between firefox-esr and thunderbird: thunderbird is built with the My proposal: Disable it for thunderbird now so we can remove rust_1_45, and enable this flag for more recent firefox (and eventually thunderbird) versions. I already confirmed that it builds and runs fine with latest rust and without this compile flag. Does this plan sound good to you otherwise? |
Firefox ESR 78.x used to have a problem with Rust >= 1.46, but it works
with latest Rust now!
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)