python38Packages.logica: init at 1.3.13 #121469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built successfully:
1 suggestion:
Result of 2 packages built successfully:
1 suggestion:
|
dotlambda
requested changes
May 2, 2021
dotlambda
requested changes
May 6, 2021
| @@ -29325,6 +29325,8 @@ in | |||
|
|
|||
| leo3-bin = callPackage ../applications/science/logic/leo3/binary.nix {}; | |||
|
|
|||
| logica = python3.pkgs.callPackage ../applications/science/logic/logica {}; | |||
There was a problem hiding this comment.
Suggested change
| logica = python3.pkgs.callPackage ../applications/science/logic/logica {}; | |
| logica = callPackage ../applications/science/logic/logica { }; |
| @@ -0,0 +1,33 @@ | |||
| { lib, buildPythonApplication, python, fetchPypi, isPy27 }: | |||
There was a problem hiding this comment.
Suggested change
| { lib, buildPythonApplication, python, fetchPypi, isPy27 }: | |
| { lib, python3 }: |
Comment on lines
+23
to
+24
| # PyPI tarball doesn't ship all the tests files, and upstream repository does | ||
| # not have a setup.py |
There was a problem hiding this comment.
They must somehow create that setup.py. So we should be able to use fetchFromGitHub and do create it in preBuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add https://logica.dev/
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)