Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.32.2 -> 1.33.1 #121805

Merged
merged 2 commits into from May 8, 2021
Merged

matrix-synapse: 1.32.2 -> 1.33.1 #121805

merged 2 commits into from May 8, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 5, 2021 •
edited

Motivation for this change

ChangeLog: https://github.com/matrix-org/synapse/releases/tag/v1.33.0, https://github.com/matrix-org/synapse/releases/tag/v1.33.1

Already running it on my server, but let's wait a bit with merging though given what happened to 1.32 :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label May 5, 2021
@ofborg ofborg bot requested review from pacien and mjlbach May 5, 2021 14:31
@sumnerevans
Copy link
Member

https://github.com/matrix-org/synapse/releases/tag/v1.33.1

@Ma27
Copy link
Member Author

Ma27 commented May 6, 2021

Yeah, seen it. Currently building the new package :)

@Ma27 Ma27 requested a review from ajs124 May 6, 2021 13:53
@Ma27 Ma27 changed the title matrix-synapse: 1.32.2 -> 1.33.0 matrix-synapse: 1.32.2 -> 1.33.1 May 6, 2021
@ajs124
Copy link
Member

ajs124 commented May 6, 2021

1.33.0 vs .1 should be a no-op for us, right?

@Ma27
Copy link
Member Author

Ma27 commented May 6, 2021

Yes.

@Ma27 Ma27 merged commit 0f495b5 into NixOS:master May 8, 2021
@Ma27 Ma27 deleted the matrix-synapse branch May 8, 2021 16:13
@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 8, 2021
@Ma27
Copy link
Member Author

Ma27 commented May 8, 2021

Ported to stable as c03803a, e459ad6, 1b688ca (only relevant on 20.09)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@fadenb fadenb Awaiting requested review from fadenb

@Ralith Ralith Awaiting requested review from Ralith

@Ekleog Ekleog Awaiting requested review from Ekleog

@mguentner mguentner Awaiting requested review from mguentner

@pacien pacien Awaiting requested review from pacien

@mjlbach mjlbach Awaiting requested review from mjlbach

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @sumnerevans @ajs124