New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonRemoveTestsDirHook: also remove /test #121858
Closed
drewrisinger
wants to merge
1
commit into
NixOS:staging
from
drewrisinger:dr-pr-python-remove-test-dir-hook
Closed
pythonRemoveTestsDirHook: also remove /test #121858
drewrisinger
wants to merge
1
commit into
NixOS:staging
from
drewrisinger:dr-pr-python-remove-test-dir-hook
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages have their tests installed at ./test, not just ./tests. This covers that use case by removing both.
Result of 914 packages marked as broken and skipped:
23993 packages skipped due to time constraints:
276 packages built successfully:
|
Merged into my local working tree for python-unstable. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Python packages tend to have their tests installed at either
./test
or./tests
. Previously, we had only covered the second case, ignoring the first. I just ran into a collision between two packages'/test
directory, and thought it would be worth adding.I didn't run tests because this is going to rebuild every single python package...
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)