Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonRemoveTestsDirHook: also remove /test #121858

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Python packages tend to have their tests installed at either ./test or ./tests. Previously, we had only covered the second case, ignoring the first. I just ran into a collision between two packages' /test directory, and thought it would be worth adding.

I didn't run tests because this is going to rebuild every single python package...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Some packages have their tests installed at ./test, not just ./tests.
This covers that use case by removing both.
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121858 at 6819656 run on x86_64-linux 1

914 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
23993 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • Literate
  • MACS2
  • MIDIVisualizer
  • MMA
  • ...
276 packages built successfully:
  • dav1d
  • docutils (python38Packages.docutils)
  • epoxy
  • fribidi
  • gi-docgen
  • gtk-doc (gnome2.gtkdoc)
  • jpylyzer (python38Packages.jpylyzer)
  • libGL
  • libdrm
  • libglvnd
  • libmicrodns
  • libpsl
  • libsysprof-capture
  • libvdpau
  • meson
  • python38Packages.Babel
  • python38Packages.Mako
  • python38Packages.PyStemmer
  • python38Packages.alabaster
  • python38Packages.apipkg
  • python38Packages.appdirs
  • python38Packages.astor
  • python38Packages.async-timeout
  • python38Packages.async_generator
  • python38Packages.atomicwrites
  • python38Packages.attrs
  • python38Packages.automat
  • python38Packages.backcall
  • python38Packages.backports-entry-points-selectable
  • python38Packages.blinker
  • python38Packages.brotli
  • python38Packages.certifi
  • python38Packages.click
  • python38Packages.cloudpickle
  • python38Packages.colorama
  • python38Packages.constantly
  • python38Packages.cookies
  • python38Packages.coverage
  • python38Packages.cppy
  • python38Packages.crashtest
  • python38Packages.cycler
  • python38Packages.cython
  • python38Packages.dateutil (python38Packages.python-dateutil)
  • python38Packages.ddt
  • python38Packages.decorator
  • python38Packages.defusedxml
  • python38Packages.deprecation
  • python38Packages.distlib
  • python38Packages.django (python38Packages.django_2)
  • python38Packages.ecdsa
  • python38Packages.eradicate
  • python38Packages.et_xmlfile
  • python38Packages.execnet
  • python38Packages.extras
  • python38Packages.filelock
  • python38Packages.fixtures
  • python38Packages.flake8
  • python38Packages.flaky
  • python38Packages.flit-core
  • python38Packages.freezegun
  • python38Packages.future
  • python38Packages.gitdb
  • python38Packages.gunicorn
  • python38Packages.gyp
  • python38Packages.hijri-converter
  • python38Packages.hyperlink
  • python38Packages.idna
  • python38Packages.imagesize
  • python38Packages.importlib-metadata
  • python38Packages.incremental
  • python38Packages.iniconfig
  • python38Packages.intreehooks
  • python38Packages.ipython_genutils
  • python38Packages.iso8601
  • python38Packages.isodate
  • python38Packages.itsdangerous
  • python38Packages.jdcal
  • python38Packages.jinja2
  • python38Packages.jupyterlab-pygments
  • python38Packages.lazy-object-proxy
  • python38Packages.libevdev
  • python38Packages.limits
  • python38Packages.linecache2
  • python38Packages.lxml
  • python38Packages.m2r
  • python38Packages.markdown
  • python38Packages.markupsafe
  • python38Packages.mccabe
  • python38Packages.mistune (python38Packages.mistune_0_8)
  • python38Packages.mock
  • python38Packages.mongoengine
  • python38Packages.more-itertools
  • python38Packages.mpmath
  • python38Packages.munkres
  • python38Packages.nest-asyncio
  • python38Packages.nose
  • python38Packages.nose-exclude
  • python38Packages.nose_warnings_filters
  • python38Packages.nosexcover
  • python38Packages.olefile
  • python38Packages.ordereddict
  • python38Packages.outcome
  • python38Packages.packaging
  • python38Packages.pandocfilters
  • python38Packages.parameterized
  • python38Packages.pastel
  • python38Packages.pbr
  • python38Packages.pep517
  • python38Packages.pexpect
  • python38Packages.pip
  • python38Packages.pipBuildHook
  • python38Packages.pipInstallHook
  • python38Packages.pkgconfig
  • python38Packages.pkginfo
  • python38Packages.pluggy
  • python38Packages.ply
  • python38Packages.pretend
  • python38Packages.prometheus_client
  • python38Packages.psutil
  • python38Packages.ptyprocess
  • python38Packages.purl
  • python38Packages.py
  • python38Packages.py-cpuinfo
  • python38Packages.pyasn1
  • python38Packages.pyasn1-modules
  • python38Packages.pycodestyle
  • python38Packages.pycparser
  • python38Packages.pydocstyle
  • python38Packages.pyext
  • python38Packages.pyflakes
  • python38Packages.pygments
  • python38Packages.pyhamcrest
  • python38Packages.pylama
  • python38Packages.pymeeus
  • python38Packages.pymongo
  • python38Packages.pyparsing
  • python38Packages.pyperf
  • python38Packages.pysocks
  • python38Packages.pytest (python38Packages.pytest_6)
  • python38Packages.pytest-asyncio
  • python38Packages.pytest-benchmark
  • python38Packages.pytestcov (python38Packages.pytest-cov)
  • python38Packages.pytest-expect
  • python38Packages.pytest-flake8
  • python38Packages.pytest-forked
  • python38Packages.pytest-freezegun
  • python38Packages.pytest-mock
  • python38Packages.pytestrunner (python38Packages.pytest-runner)
  • python38Packages.pytest-subtests
  • python38Packages.pytest-xdist (python38Packages.pytest_xdist)
  • python38Packages.pytestCheckHook
  • python38Packages.pythonCatchConflictsHook
  • python38Packages.pythonRemoveTestsDirHook
  • python38Packages.python_mimeparse
  • python38Packages.pytoml
  • python38Packages.pytz
  • python38Packages.pyyaml
  • python38Packages.redis
  • python38Packages.rednose
  • python38Packages.rsa
  • python38Packages.ruamel-base (python38Packages.ruamel_base)
  • python38Packages.ruamel-yaml (python38Packages.ruamel_yaml)
  • python38Packages.ruamel-yaml-clib (python38Packages.ruamel_yaml_clib)
  • python38Packages.semantic-version
  • python38Packages.send2trash
  • python38Packages.setuptools
  • python38Packages.setuptools-rust
  • python38Packages.setuptools-scm (python38Packages.setuptools_scm)
  • python38Packages.setuptoolsBuildHook
  • python38Packages.setuptoolsCheckHook
  • python38Packages.simplejson
  • python38Packages.six
  • python38Packages.smartypants
  • python38Packages.smmap
  • python38Packages.snowballstemmer
  • python38Packages.sortedcontainers
  • python38Packages.soupsieve
  • python38Packages.sphinxcontrib-applehelp
  • python38Packages.sphinxcontrib-devhelp
  • python38Packages.sphinxcontrib-htmlhelp
  • python38Packages.sphinxcontrib-jsmath
  • python38Packages.sphinxcontrib-qthelp
  • python38Packages.sphinxcontrib-serializinghtml
  • python38Packages.sphinxcontrib-websupport
  • python38Packages.sqlparse
  • python38Packages.sure
  • python38Packages.terminado
  • python38Packages.termstyle
  • python38Packages.testpath
  • python38Packages.testresources
  • python38Packages.testscenarios
  • python38Packages.testtools
  • python38Packages.text-unidecode
  • python38Packages.toml
  • python38Packages.tomlkit
  • python38Packages.tornado
  • python38Packages.traceback2
  • python38Packages.typing-extensions
  • python38Packages.typogrify
  • python38Packages.tzlocal
  • python38Packages.u-msgpack-python
  • python38Packages.ukpostcodeparser
  • python38Packages.unittest2
  • python38Packages.urllib3
  • python38Packages.vcversioner
  • python38Packages.wcwidth
  • python38Packages.webencodings
  • python38Packages.wheel
  • python38Packages.wheelUnpackHook
  • python38Packages.whoosh
  • python38Packages.wrapt
  • python38Packages.xlwt
  • python38Packages.zipp
  • python38Packages.zope_event
  • python38Packages.zope_exceptions
  • python38Packages.zope_interface
  • python39Packages.atomicwrites
  • python39Packages.attrs
  • python39Packages.coverage
  • python39Packages.docutils
  • python39Packages.importlib-metadata
  • python39Packages.iniconfig
  • python39Packages.more-itertools
  • python39Packages.nose
  • python39Packages.packaging
  • python39Packages.pip
  • python39Packages.pipBuildHook
  • python39Packages.pipInstallHook
  • python39Packages.pluggy
  • python39Packages.py
  • python39Packages.pygments
  • python39Packages.pyparsing
  • python39Packages.pythonCatchConflictsHook
  • python39Packages.pythonRemoveTestsDirHook
  • python39Packages.setuptools
  • python39Packages.setuptools-scm (python39Packages.setuptools_scm)
  • python39Packages.setuptoolsBuildHook
  • python39Packages.setuptoolsCheckHook
  • python39Packages.six
  • python39Packages.sortedcontainers
  • python39Packages.toml
  • python39Packages.wcwidth
  • python39Packages.wheel
  • python39Packages.zipp
  • rlottie
  • sipvicious
  • swaykbdd
  • volk
  • xkeyboard_config (xorg.xkeyboardconfig)
  • xorg.libICE
  • xorg.libSM
  • xorg.libX11
  • xorg.libXScrnSaver
  • xorg.libXau
  • xorg.libXcomposite
  • xorg.libXcursor
  • xorg.libXdamage
  • xorg.libXdmcp
  • xorg.libXext
  • xorg.libXfixes
  • xorg.libXi
  • xorg.libXinerama
  • xorg.libXrandr
  • xorg.libXrender
  • xorg.libXt
  • xorg.libXtst
  • xorg.libXv
  • xorg.libXxf86vm
  • xorg.libxcb
  • xorg.libxshmfence
  • xorg.xcbutil
  • xorg.xcbutilimage
  • xorg.xcbutilkeysyms
  • xorg.xcbutilrenderutil
  • xorg.xcbutilwm
  • xorg.xorgproto

@mweinelt mweinelt added this to In progress in Python batch upgrade via automation Jun 17, 2021
@mweinelt
Copy link
Member

Merged into my local working tree for python-unstable. Thank you.

@mweinelt mweinelt closed this Jun 18, 2021
Python batch upgrade automation moved this from In progress to Done Jun 18, 2021
@drewrisinger drewrisinger deleted the dr-pr-python-remove-test-dir-hook branch June 21, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants