Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plexamp: 3.4.4 -> 3.4.6 #121887

Merged
merged 4 commits into from May 24, 2021
Merged

plexamp: 3.4.4 -> 3.4.6 #121887

merged 4 commits into from May 24, 2021

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 6, 2021 •
edited

Motivation for this change

Also added update script, hope to add this to nixpkgs-upkeep.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from killercup May 6, 2021 06:42
@Synthetica9 Synthetica9 mentioned this pull request May 6, 2021
Closed
@afontaine
Copy link
Contributor

Result of nixpkgs-review pr 121887 run on x86_64-linux 1

1 package built:
  • plexamp

@afontaine
Copy link
Contributor

plexamp builds and runs great, my favourite visualizer is back!

I didn't test the update script though...

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/533

@Synthetica9 Synthetica9 changed the title plexamp: 3.4.4 -> 3.4.5 plexamp: 3.4.4 -> 3.4.6 May 24, 2021
@SuperSandro2000 SuperSandro2000 merged commit 741c61b into NixOS:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontaine afontaine afontaine approved these changes

@killercup killercup Awaiting requested review from killercup

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @afontaine @nixos-discourse @SuperSandro2000