Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mcstatus: 5.1.4 -> 5.2.0 #121955

Merged
merged 1 commit into from May 9, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 6, 2021

Motivation for this change

Update to latest upstream release 5.2.0

Change log: https://github.com/Dinnerbone/mcstatus/releases/tag/v5.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 6, 2021

Result of nixpkgs-review pr 121955 at 1966c73 run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.mcstatus
  • python39Packages.mcstatus

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121955 at 1966c73 run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.mcstatus
  • python39Packages.mcstatus

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@fabaff
Copy link
Member Author

fabaff commented May 6, 2021

Result of nixpkgs-review pr 121955 run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built:
  • python38Packages.mcstatus
  • python39Packages.mcstatus

@fabaff
Copy link
Member Author

fabaff commented May 6, 2021

Failure seems unrelated at first glance.

building '/nix/store/mzwjw9chvndn1rgw1hka6hl5970cqsa7-homeassistant-2021.5.0.drv'...
builder for '/nix/store/mzwjw9chvndn1rgw1hka6hl5970cqsa7-homeassistant-2021.5.0.drv' failed with exit code 1; last 10 log lines:
      gc.collect()
  
  tests/components/shell_command/test_init.py::test_do_no_run_forever[pyloop]
    /nix/store/q6gfck5czr67090pwm53xrdyhpg6bx67-python3-3.8.9/lib/python3.8/asyncio/unix_events.py:917: RuntimeWarning: A loop is being detached from a child watcher with pending handlers
      warnings.warn(
  
  -- Docs: https://docs.pytest.org/en/stable/warnings.html
  =========================== short test summary info ============================
  FAILED tests/components/mobile_app/test_webhook.py::test_webhook_handle_get_config[pyloop]
  = 1 failed, 8656 passed, 5 skipped, 466 warnings, 1 rerun in 1242.97s (0:20:42) =
``

@fabaff fabaff mentioned this pull request May 6, 2021
10 tasks
Home Assistant automation moved this from To do to Reviewed May 9, 2021
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 121955 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.mcstatus
  • python39Packages.mcstatus

@jonringer jonringer merged commit 7c58a1e into NixOS:master May 9, 2021
Home Assistant automation moved this from Reviewed to Done May 9, 2021
@fabaff fabaff deleted the bump-mcstatus branch May 9, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants