Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hdate: init 0.10.2 #120250

Merged
merged 3 commits into from May 7, 2021
Merged

python3Packages.hdate: init 0.10.2 #120250

merged 3 commits into from May 7, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 22, 2021

Motivation for this change

Python module for Jewish/Hebrew date and Zmanim

https://github.com/py-libhdate/py-libhdate

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff marked this pull request as draft April 22, 2021 18:29
@fabaff
Copy link
Member Author

fabaff commented Apr 22, 2021

Another thing to solve:

builder for '/nix/store/l904an6fl3aik0b312rx6sh67g6l1wak-python3.8-hdate-0.10.2.drv' failed with exit code 1; last 10 log lines:
  Successfully built hdate
  Finished creating a wheel...
  Finished executing pipBuildPhase
  installing
  Executing pipInstallPhase
  /build/source/dist /build/source
  Processing ./hdate-0.10.0-py2.py3-none-any.whl
  Requirement already satisfied: pytz<2022,>=2021 in /nix/store/wp2x28vy8a6mqim5sxwfzlgyy17lm1qv-python3.8-pytz-2021.1/lib/python3.8/site-packages (from hdate==0.10.0) (2021.1)
  ERROR: Could not find a version that satisfies the requirement astral<3.0,>=2.2; python_version >= "3.6" and python_version < "4.0" (from hdate)
  ERROR: No matching distribution found for astral<3.0,>=2.2; python_version >= "3.6" and python_version < "4.0"
cannot build derivation '/nix/store/nb8kd0gpwb6xk1zjy5g62m3hk9pk9z77-homeassistant-2021.4.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kr3809948zffxs627qk41md8665gl97y-env.drv': 1 dependencies couldn't be built

There seem to be a version mismatch (0.10.0 instead of 0.10.2).

@mweinelt
Copy link
Member

ERROR: Could not find a version that satisfies the requirement astral<3.0,>=2.2; python_version >= "3.6" and python_version < "4.0" (from hdate)

That is odd, given that we have astral 2.2.

@mweinelt
Copy link
Member

mweinelt commented Apr 22, 2021

@fabaff
Copy link
Member Author

fabaff commented Apr 26, 2021

That is odd, given that we have astral 2.2.

Home Assistant < 2021.4.x wants astral-1.10.1. Support for astral-2.2 will come with 2021.5.x.

@mweinelt mweinelt added this to To do in Home Assistant via automation May 4, 2021
@mweinelt mweinelt moved this from To do to WIP in Home Assistant May 4, 2021
@fabaff

This comment has been minimized.

@fabaff
Copy link
Member Author

fabaff commented May 6, 2021

test_webhook_handle_get_config is failing as in #121955

builder for '/nix/store/2gs18qwvw75kq2x8x9dalxrphy9v3m1n-homeassistant-2021.5.0.drv' failed with exit code 1; last 10 log lines:
      gc.collect()
  
  tests/components/shell_command/test_init.py::test_do_no_run_forever[pyloop]
    /nix/store/q6gfck5czr67090pwm53xrdyhpg6bx67-python3-3.8.9/lib/python3.8/asyncio/unix_events.py:917: RuntimeWarning: A loop is being detached from a child watcher with pending handlers
      warnings.warn(
  
  -- Docs: https://docs.pytest.org/en/stable/warnings.html
  =========================== short test summary info ============================
  FAILED tests/components/mobile_app/test_webhook.py::test_webhook_handle_get_config[pyloop]
  = 1 failed, 8735 passed, 5 skipped, 466 warnings, 1 rerun in 1235.82s (0:20:35) =

@fabaff fabaff marked this pull request as ready for review May 6, 2021 22:29
@mweinelt
Copy link
Member

mweinelt commented May 6, 2021

You posted an unrelated warning, not the actual error.

@fabaff
Copy link
Member Author

fabaff commented May 6, 2021

That's what I get from nix-review per default. test_webhook_handle_get_config doesn't always fail.

@fabaff
Copy link
Member Author

fabaff commented May 6, 2021

Result of nixpkgs-review pr 120250 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.hdate
  • python39Packages.hdate

@mweinelt
Copy link
Member

mweinelt commented May 6, 2021

That's what I get from nix-review per default. test_webhook_handle_get_config doesn't always fail.

That's a shame. Please try nix-build -A home-assistant instead, possibly with --check.

@fabaff
Copy link
Member Author

fabaff commented May 7, 2021

That's a shame. Please try nix-build -A home-assistant instead, possibly with --check.

With nix-build and on a different host all tests are passing.

Home Assistant automation moved this from WIP to Reviewed May 7, 2021
@mweinelt mweinelt merged commit 860b457 into NixOS:master May 7, 2021
Home Assistant automation moved this from Reviewed to Done May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants