New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.plugwise: 0.9.3 -> 0.9.4 #121960
Conversation
Result of 1 package failed to build:
2 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 1 package failed to build:
2 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
, pytz | ||
, python-dateutil | ||
, semver | ||
, fetchFromGitHub | ||
, jsonpickle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently needed in propagatedBuildinputs, as imports are failing in the home-assistant test run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, jsonpickle
is in requirements_test.txt
, I wish we could also have test dependencies autogenerated from the manifest, but there does not seem to be a field for that upstream and the requirements_test.txt
is tracked manually.
Drop asynctest, it was dropped back in january upstream. These dependencies are sadly not part of the manifest, that we are parsing.
Motivation for this change
Update to latest upstream release 0.9.4
Change log: https://github.com/plugwise/python-plugwise/releases/tag/0.9.4
Incl. cleaning up and Home Assistant test.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)