Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.plugwise: 0.9.3 -> 0.9.4 #121960

Merged
merged 3 commits into from May 10, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 6, 2021

Motivation for this change

Update to latest upstream release 0.9.4

Change log: https://github.com/plugwise/python-plugwise/releases/tag/0.9.4

Incl. cleaning up and Home Assistant test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff added this to To do in Home Assistant via automation May 6, 2021
@fabaff fabaff changed the title Bump plugwise python3Packages.plugwise: 0.9.3 -> 0.9.4 May 6, 2021
@ofborg ofborg bot requested review from Mic92, globin and mweinelt May 6, 2021 22:38
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 6, 2021

Result of nixpkgs-review pr 121960 at eceb958f run on aarch64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.plugwise
  • python39Packages.plugwise

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121960 at eceb958f run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.plugwise
  • python39Packages.plugwise

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

, pytz
, python-dateutil
, semver
, fetchFromGitHub
, jsonpickle
Copy link
Member

@mweinelt mweinelt May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently needed in propagatedBuildinputs, as imports are failing in the home-assistant test run.

Copy link
Member

@mweinelt mweinelt May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, jsonpickle is in requirements_test.txt, I wish we could also have test dependencies autogenerated from the manifest, but there does not seem to be a field for that upstream and the requirements_test.txt is tracked manually.

fabaff and others added 3 commits May 10, 2021 20:53
Drop asynctest, it was dropped back in january upstream. These
dependencies are sadly not part of the manifest, that we are parsing.
@mweinelt mweinelt merged commit 008880b into NixOS:master May 10, 2021
Home Assistant automation moved this from To do to Done May 10, 2021
@ofborg ofborg bot requested a review from mweinelt May 10, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants