Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: xvfb_run -> xvfb-run #122003

Merged
merged 2 commits into from May 8, 2021
Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented May 7, 2021

Motivation for this change

Consistency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Did you use ripgrep to double check that you didn't miss something that is not always evaluated?

@fricklerhandwerk
Copy link
Contributor

I checked. Nothing left. Alias is in place.

@github-actions github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 8, 2021
@roberth
Copy link
Member Author

roberth commented May 8, 2021

Did you use ripgrep to double check that you didn't miss something that is not always evaluated?

Yes.

  • Semi-automated find and replace with vscode
  • git add --patch
  • git show -U0 --word-diff --word-diff-regex=. to check
  • ofborg

I'll merge this after ofborg, to avoid another merge conflict.

@roberth roberth merged commit 8823855 into NixOS:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants