pythonPackages.Markups: disable some failing tests #122038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Result of 3 packages built:
|
|
Result of 3 packages built successfully:
Result of 3 packages built successfully:
|
|
ZHF: #122042 |
mweinelt
reviewed
May 7, 2021
| propagatedBuildInputs = [ python-markdown-math ]; | ||
|
|
||
| checkInputs = [ pytestCheckHook markdown docutils pygments ]; | ||
| disabledTests = [ | ||
| # these tests fail on the current version |
There was a problem hiding this comment.
Yes, but why do they fail? Did you investigate the reason?
There was a problem hiding this comment.
@SuperSandro2000 Did you look into these tests?
There was a problem hiding this comment.
I thought we agreed, that disabling tests should come with some mild investigation. There is always the chance that it is an indicator that something is going wrong with the package.
10 tasks
|
gah, sorry, forgot about this PR :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)