Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyxnat: add missing six dependency #122075

Merged
merged 1 commit into from May 7, 2021
Merged

python3Packages.pyxnat: add missing six dependency #122075

merged 1 commit into from May 7, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 7, 2021

Motivation for this change

ERROR: Could not find a version that satisfies the requirement six>=1.15 (from pyxnat)

https://nix-cache.s3.amazonaws.com/log/nhl96h1cf60iwmv3fngrqyi0d24qf7z5-python3.8-pyxnat-1.4.drv

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122075 run on x86_64-linux 1

2 packages built:
  • python38Packages.pyxnat
  • python39Packages.pyxnat

@jonringer jonringer merged commit e35cbc0 into NixOS:master May 7, 2021
@mweinelt mweinelt deleted the python/pyxnat branch May 7, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer