Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.Frames-streamly: fix build #122227

Closed
wants to merge 1 commit into from
Closed

haskellPackages.Frames-streamly: fix build #122227

wants to merge 1 commit into from

Conversation

divanorama
Copy link
Contributor

@divanorama divanorama commented May 8, 2021 •
edited

  • use relude_1_0_0_1 to satisfy bounds
  • add missing file example_data/acs100k.csv upstream issue

https://hydra.nixos.org/build/142525099/nixlog/1

ZHF: #122042

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@divanorama
haskellPackages.Frames-streamly: fix build
dea5076 
- use relude_1_0_0_1 to satisfy bounds
- add missing file example_data/acs100k.csv [upstream issue](adamConnerSax/Frames-streamly#1)

https://hydra.nixos.org/build/142525099/nixlog/1

ZHF: NixOS#122042
@jonringer
Copy link
Contributor

cc @NixOS/haskell

sternenseemann
sternenseemann requested changes May 8, 2021
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
Frames-streamly = overrideCabal (super.Frames-streamly.override { relude = super.relude_1_0_0_1; }) (drv: {
# https://github.com/adamConnerSax/Frames-streamly/issues/1
patchPhase = ''
cat > example_data/acs100k.csv <<EOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use overrideSrc and just fetch the source from github instead of using the sdist from hackage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be an option, but there are no tags/releases on github and full file is several MB so thought a 2-line version would do

@sternenseemann
Copy link
Member

Thanks for doing these haskell fixups! We generally try to stabilize the set on a separate branch (haskell-updates) and merge it into master regularly. Therefore when looking for build failures the haskell-updates jobset is a good point of reference. If you could target haskell-updates as well that'd be nice, since editing the configuration-*.nix files on two branches simutaneously just causes merge conflicts.

@divanorama
Copy link
Contributor Author

Are there other (language/group) stabilization branches? Would be nice to list them in #122042

@divanorama
Copy link
Contributor Author

retargeted to haskell-updates branch in #122319

@divanorama divanorama closed this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann requested changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@divanorama @jonringer @sternenseemann