Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.Frames-streamly: fix build #122319

Closed
wants to merge 1 commit into from
Closed

haskellPackages.Frames-streamly: fix build #122319

wants to merge 1 commit into from

Conversation

divanorama
Copy link
Contributor

  • use relude_1_0_0_1 to satisfy bounds
  • add missing file example_data/acs100k.csv upstream issue

https://hydra.nixos.org/build/142525099/nixlog/1

ZHF: #122042

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@divanorama
haskellPackages.Frames-streamly: fix build
91bb7de 
- use relude_1_0_0_1 to satisfy bounds
- add missing file example_data/acs100k.csv [upstream issue](adamConnerSax/Frames-streamly#1)

https://hydra.nixos.org/build/142525099/nixlog/1

ZHF: NixOS#122042
@divanorama divanorama mentioned this pull request May 9, 2021
Closed
10 tasks
@maralorn
Copy link
Member

maralorn commented May 9, 2021

I have cherry-picked this change onto haskell-updates.

Thank you!

@maralorn maralorn closed this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@divanorama @maralorn