scli: init at 0.6.1 #122315
scli: init at 0.6.1 #122315
Conversation
|
Result of 1 package built:
|
| }; | ||
| propagatedBuildInputs = [ signal-cli urwid urwid-readline dbus ]; | ||
| dontBuild = true; | ||
| doCheck = false; |
There was a problem hiding this comment.
It might be nice to include a checkPhase of just running scli --help or something similar to ensure it works. Maybe you could test its ability to pickup signal-cli too, once you get that to work.
There was a problem hiding this comment.
Unfortunately scli tries to create a ~/.local/share/scli directory upon initial run, which nix freaks out about:
https://gist.github.com/alex-eyre/dd3a0a8d8c132715725d703bd9841dac
I don't know if there's anything we can do about that :/
There was a problem hiding this comment.
You could probably do something like this:
XDG_DATA_HOME=$(mktemp -d)
XDG_CONFIG_HOME=$(mktemp -d)
There was a problem hiding this comment.
Thanks for the help! I've implemented a really basic invocation test in the checkPhase, but I'm not sure what more testing we can do without somehow logging into signal 🤔
12e50ce0117902c60eb880aacc672de6e23d6b25
|
Result of 1 package built:
|
alexeyre
requested review from
SuperSandro2000 and
Pacman99
and removed request for
SuperSandro2000 and
Pacman99
|
This actually requires zkgroup for full functionality, which according to docs should be embedded into signal-cli itself, so I'll have a look at doing that. cc @ivan @erictapen |
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| install -m755 -D scli $out/bin/scli |
There was a problem hiding this comment.
The shebang at https://github.com/isamert/scli/blob/0c5de11edc8aaa7a9547d92376db0e0b8195836b/scli#L1 needs fixing.
scli: add license scli: add basic checkPhase scli: apply formatting changes from @SuperSandro2000 Co-authored-by: Sandro <sandro.jaeckel@gmail.com> scli: update src sha256 scli: remove chmod from checkPhase scli: add pathShebangs
Motivation for this change
Response to #120615
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Improvements To-Do