Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scli: 0.6.1 -> 0.6.3 #127797

Merged
merged 1 commit into from Jun 23, 2021
Merged

scli: 0.6.1 -> 0.6.3 #127797

merged 1 commit into from Jun 23, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jun 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@ethancedwards8
Copy link
Member

Result of nixpkgs-review pr 127797 run on x86_64-linux 1

1 package built:
  • scli

Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works, diff lgtm

@dotlambda
Copy link
Member Author

works

Really? You didn't hit AsamK/signal-cli#315?

@endocrimes
Copy link
Member

@dotlambda weirdly, no, but my dbus setup is cursed (and i didn't go too deep into learning how it works beyond rudimentary can i get it to run)

@dotlambda
Copy link
Member Author

@endocrimes If you feel like sharing the setup, I'd be interested.

@SuperSandro2000 SuperSandro2000 merged commit e35ddac into NixOS:master Jun 23, 2021
@dotlambda dotlambda deleted the scli-0.6.3 branch June 23, 2021 11:30
@alexeyre
Copy link
Contributor

this has been on my todo list for a bit but I've been a bit snowed under at work, thank you for getting round to it.

In regards to using { python3, ... } as an argument and using python3.pkgs, I was specifically advised by @jonringer to not do that, and I'm a bit alarmed that you changed it back just for bumping the version number. Read the original PR for some more context: #122315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants