New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chatty: init at 0.3.2 #122373
chatty: init at 0.3.2 #122373
Conversation
I agree on dropping the wrapper approach. And chatty is moving towards putting plugins in tree, so its pretty unnecessary. It looks like purple-mm-sms will be moved into chatty itself soon. Keep in mind many purple plugins don't actually work with chatty. I believe there is a hardcoded list of plugins the app supports. For phosh/mobile usage, it might be good to include chatty with purple-mm-sms as a default package in the phosh module. Perhaps that can be saved for a future PR. |
I was thinking of adding all supported plugins to the |
Thats a good idea. Make sure not to include Also another consideration, should an override just append to the default plugin list or should it overwrite the plugin list entirely? |
How do I use the native one?
I think overwriting it is the better choice, as people who override the package know which plugins exactly they want. |
I had to do |
Skimming through the code makes it seem like native matrix support is always used if experimental features are enabled, regarless of whether purple-matrix is installed. But I still have to confirm that. |
If thats true, then purple-matrix can just be included by default
That makes sense to me |
I can't seem to get my Matrix account to work. I put in my data and it shows an account was created. However, my account keeps showing as disconnected and even using |
FYI, #129230 is introducing |
It'd be great to get chatty in, even without all or any plugins (XMPP is included by default), to provide a Phosh-native chat client. |
@tomfitzhenry If you can confirm that this is working, we can definitely add it. I just couldn't get it to work with my Matrix account and didn't bother with making an XMPP one. |
Done. I was able to login into an XMPP room and communicate, with chatty. |
I've been using this for 3 weeks now without issue. +1 to merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Who wants to step up to be chatty's maintainer? Since I can't test it, I shouldn't be. |
I am happy to be chatty's maintainer. I've been using this package for 7 weeks now, and am happy with the PR as-is. Please add me as the maintainer. |
Co-authored-by: Jordi Masip <jordi@masip.cat>
366c88f
to
ba0b032
Compare
Thanks! I left myself in so I'm still pinged when chatty is modified. |
Result of 1 package built:
|
Yes, I will. I'm subscribed to https://source.puri.sm/Librem5/chatty/-/tags?format=atom too, for future releases. |
|
Motivation for this change
continuation of #94820
I decided against the wrapper approach as that makes it hard to override other things and chatty doesn't take long to build. If a wrapper is preferred though, I'll change it of course.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I still have to do extensive testing of all the plugins.
It would be nice if libpurple were separate from pidgin.