Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-modules: update cran and bioc package lists #122409

Closed
wants to merge 1 commit into from

Conversation

PhDyellow
Copy link

nix-build test-evaluation.nix --dry-run passes.

Arrow is now v4.0.0, which matches with Arrow-cpp
version in master, see #81761.

Removes "DSpat" "cit" "ProbForecastGOP" "DSpat"
"dgmb" "rtiff" "rpg" from default.nix, these packages
have been removed from CRAN.

Motivation for this change

R package set is out of date.
Issue #81761 manually updated a single package, but recommended updating all packages when possible.
Used modified code from PR #122408, but the result should be independent of that PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@PhDyellow
Copy link
Author

Fixed up some packages that failed to build with the new CRAN and BioC verions.

@peti
Copy link
Member

peti commented May 11, 2021

Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates.

@PhDyellow
Copy link
Author

I didn't know about the test builds, very useful!

I see a lot of failed builds happen because of packages that were removed from CRAN.

This was referenced Jun 22, 2021
Fix or remove packages that had broken
during the update.
@PhDyellow
Copy link
Author

Closing in favour of #121819

@PhDyellow PhDyellow closed this Jun 25, 2021
@PhDyellow PhDyellow deleted the bump_r_bioc_cran branch August 23, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants