Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: unstable-2021-04-17 -> unstable-2021-05-13 #122904

Merged
merged 1 commit into from May 14, 2021
Merged

beets: unstable-2021-04-17 -> unstable-2021-05-13 #122904

merged 1 commit into from May 14, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Routine update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 122904 run on x86_64-linux 1

4 packages built:
  • beets
  • beetsExternalPlugins.alternatives
  • beetsExternalPlugins.copyartifacts
  • beetsExternalPlugins.extrafiles

@lovesegfault
Copy link
Member Author

I'm deploying this to my media server right now for more testing

@ofborg ofborg bot requested review from pjones and aszlig May 13, 2021 22:38
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122904 at 0ccad64 run on aarch64-linux 1

4 packages built successfully:
  • beets
  • beetsExternalPlugins.alternatives
  • beetsExternalPlugins.copyartifacts
  • beetsExternalPlugins.extrafiles

@lovesegfault
Copy link
Member Author

Imported a bunch of music, updated the db, used some plugins.

All is well :)

@mweinelt
Copy link
Member

Yup, looking good here as well.

@mweinelt mweinelt merged commit 5d59c3f into NixOS:master May 14, 2021
@lovesegfault lovesegfault deleted the beets-2021-05-13 branch May 14, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

@pjones pjones Awaiting requested review from pjones

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @r-rmcgibbo @mweinelt