Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyvesync: 1.3.1 -> 1.4.0 #122906

Merged
merged 2 commits into from May 14, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 13, 2021

Motivation for this change

Update to latest upstream release 1.4.0

Change log: https://github.com/webdjoe/pyvesync/releases/tag/1.4.0

Enable Home Assistant tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested a review from FRidh as a code owner May 13, 2021 22:09
@fabaff fabaff added this to To do in Home Assistant via automation May 13, 2021
@fabaff fabaff requested a review from jonringer as a code owner May 13, 2021 22:09
@fabaff
Copy link
Member Author

fabaff commented May 13, 2021

@ofborg test home-assistant

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 13, 2021

Result of nixpkgs-review pr 122906 at 156d266 run on aarch64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.pyvesync
  • python39Packages.pyvesync

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 122906 at 156d266 run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.pyvesync
  • python39Packages.pyvesync

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Home Assistant automation moved this from To do to Reviewed May 14, 2021
@mweinelt mweinelt merged commit f9d8231 into NixOS:master May 14, 2021
Home Assistant automation moved this from Reviewed to Done May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants